New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable import.meta by default in @babel/parser (#11364) #11406
Conversation
kik-o
commented
Apr 11, 2020
•
edited by JLHwung
edited by JLHwung
Q | A 🗺️ |
---|---|
Fixes | Fixes #11364 |
Patch: | Moved files, removed hasPlugin() & expectPlugin ✅ |
Major: Breaking Change? | No |
Minor: New Feature? | Yes |
Tests Added + Pass? | Yes 💯 |
Documentation PR Link | |
Any Dependency Changes? | No |
License | MIT |
- Moved experimental test files for importMeta into ES2020 folder.
- Also removed checks for hasPlugin() & expectPlugin()
- Removed useless test to check if importMeta exists
packages/babel-parser/test/fixtures/core/sourcetype-unambiguous/import-meta/options.json
Outdated
Show resolved
Hide resolved
packages/babel-parser/test/fixtures/es2020/import-meta/without-dynamic-import/options.json
Outdated
Show resolved
Hide resolved
Thank you for all the incredibly useful and informative notes, guys! The following issues have been resolved:
|
@KK-O I don't see any new commit 😅 |
Sorry for the hiccup! Must have not pushed my changes but things should be good to go now 🚀 |
* move files, remove hasPlugin() & expectPlugin()
…bject • Removed "without-dynamic-import" test as • Removed unused code from the Errors object • Re-added relevant importMeta test
f69997b
to
0cf8307
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21290/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I have rebased your commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I have rebased your commits)